-
Notifications
You must be signed in to change notification settings - Fork 21
Fixed Image CTA (Portrait) Cut Off in Safari Instead of Being Responsive #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 WordPress Plugin Check Report
📊 Report
❌ Errors (12)📁 inc/classes/wpforms/wpforms-field-godam-record-frontend.php (1 error)
📁 inc/classes/wpforms/wpforms-field-godam-record-entry-view.php (1 error)
📁 inc/classes/wpforms/wpforms-field-godam-record-entry-edit.php (1 error)
📁 inc/classes/class-rewrite.php (1 error)
📁 inc/classes/class-elementor-widgets.php (1 error)
📁 inc/classes/everest-forms/everest-forms-field-godam-record-frontend.php (1 error)
📁 inc/classes/assets/class-ima-assets.php (1 error)
📁 inc/classes/assets/class-jetpack-form-assets.php (1 error)
📁 inc/classes/class-video-preview.php (1 error)
📁 inc/classes/lifter-lms/class-lifter-lms.php (1 error)
📁 inc/classes/fluentforms/class-form-submit.php (1 error)
📁 inc/classes/class-video-engagement.php (1 error)
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 readme.txt (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 inc/classes/media-library/class-media-folder-utils.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
91 |
PluginCheck.Security.DirectDB.UnescapedDBParameter | Unescaped parameter $where_clause used in $wpdb->get_var($wpdb->prepare(\n\t\t\t\t"\n\t\t\tSELECT COUNT(DISTINCT p.ID)\n\t\t\tFROM {$wpdb->posts} p\n\t\t\tINNER JOIN {$wpdb->term_relationships} tr ON p.ID = tr.object_id\n\t\t\tINNER JOIN {$wpdb->term_taxonomy} tt ON tr.term_taxonomy_id = tt.term_taxonomy_id\n\t\t\tWHERE {$where_clause}\n\t\t",\n\t\t\t\t$query_params\n\t\t\t))\n$where_clause assigned unsafely at line 82:\n $where_clause .= ' AND p.post_mime_type LIKE %s'\n$query_params[] used without escaping.\n$mime_type used without escaping. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (6 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?p=1 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?page_id=2 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?attachment_id=6 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (6 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?p=1 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?page_id=2 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?attachment_id=6 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a Safari-specific rendering issue where portrait Image CTA components were being cut off instead of scaling responsively. The solution introduces CSS container queries to enable responsive behavior based on the container size rather than viewport size, ensuring consistent cross-browser behavior.
Key Changes:
- Added container query support to
.easydam-layerto enable size-based responsive styles - Implemented responsive font sizing using
clamp()for better text scaling - Added container-based breakpoints for portrait CTA layout adjustments
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
subodhr258
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@OpuRockey I have reviewed and tested this fix, it's still cropping out a part of the CTA container, which leads to a scroll.
It should look the same as the CTA in chrome, please have a look at this recording:
Screen.Recording.2025-12-24.at.8.22.53.PM.mov
Dashboard.mp4@subodhr258 , It should be fixed by now. Could you please check again? |
|
LGTM, made a small improvement and tested with longer title and description, it is properly scrollable. |
* fix: Robust background scroll fix for iPhone 13 Pro and others (#1408) * fix: Robust background scroll fix for iPhone 13 Pro and others * fix: Check for dvh support before using it * Manual Transcode Option using Filter (#1391) * feat: Add filter to skip automatic transcoding on upload * feat: Update Transcoding text * fix: Sanitize array of ids Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * fix: Merge conflict (#1425) * Fix: Empty CTA screen on incomplete details filled. #1162 (#1244) * Fix: Empty CTA screen on incomplete details filled. #1162 * Removed default image from CTA image container * Fix fatal error if CTA image is removed from media library * display upload option if physical image is removed from media library * fix: Capitalization in text (#1430) * Feat: make analytics page responsive (#1093) * feat: responsive analytics page * fix: review automated review comments --------- Co-authored-by: Subodh Rajpopat <[email protected]> * chore: Create issue templates (#1455) * Fixed Image CTA (Portrait) Cut Off in Safari Instead of Being Responsive (#1416) * Fixed Image CTA (Portrait) Cut Off in Safari Instead of Being Responsive * Updated text wrap property for title andd description in image cta * fix: Improve Vertical Image CTA scroll behaviour --------- Co-authored-by: Subodh Rajpopat <[email protected]> * Fix - Hotspot positioning and other fixes (#1449) * fix: Hotspot positions in portrait and fullscreen * fix: Backward Compatibility with legacy hotspots * fix: Clamping based on resize and drag both * fix: Hotspot apearing over the controls * fix: Apply copilot feedbacks * fix: Use consistent hotspot size for new hotspots * fix: Add new hotspot layer with initial hotspot of the correct size * Fix poll layer skip button not updating to "Continue" after submission (#1457) * Initial plan * Fix poll confirmation detection and preserve button icon Co-authored-by: subodhr258 <[email protected]> * Refactor arrow icon creation and optimize text node search Co-authored-by: subodhr258 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: subodhr258 <[email protected]> * Fix godam-tab video mpd url source (#1462) Co-authored-by: KMchaudhary <[email protected]> * Feat/godam gallery iframe (#1429) * Implement godam-embed video page, and integrate on godam-gallery block * Implement the responsive width height for godam embed video * Implement iframe on gallery-block and remove the unwanted API calls and make code clean * Implement loading animation and improve the gallary item scroll behaviour * Fix the iframe URL issue on dynamic load * Implement iframe postMessages to trigger previous/next video load on gallery block * Conditionaly add style if godam block is rendered threw iframe * Improve the godam engagement style for iframe * Provide engagements query parameter to show engagements along with video * Add lofig to only show engagement options if engagement enabled and video is transcoded * Fix the engagment options not working issues * Add loading spinner until engagment popup is not opened * Fix the gallery block larger screen height issue * Make godam-gallery block style responsive * Introduce video close button * Fix the engagements query parameter issue for dynamically loaded gallery videos * Fix the iframe fullscreen for iOS devices * Show single CPT page on gallery-video if open_to_new_tab attributes is enabled * Resolve the copilot feedback * Hide the godam gallery modal's close button on fullscreenmode * Fix the transcoded status casing issue * Fix the godam video title issue for non-transcoded videos * Resolve PR feedback * Restirct the video scroll on forms, cta, and polls layers * Stop scrolling of video on fullscreen --------- Co-authored-by: KMchaudhary <[email protected]> * Fix: aspect ratio in godam/video block (#1460) * Fix godam block apsectRation reflection issue on block editor * Resolved copilot comments * Improve the code comment * Fix the godam/video height and aspect ratio related issue on block editor --------- Co-authored-by: KMchaudhary <[email protected]> * Fix the HLS URL quality menu issue for safari and iOS devices (#1470) Co-authored-by: KMchaudhary <[email protected]> * Fix: fullscreen layer font size (#1474) * Fix the fullscreen font-size issue for all forms, CTA, and polls layers * Address copilot comment --------- Co-authored-by: KMchaudhary <[email protected]> * Feat - Add PostHog support for GoDAM (#1342) * feat: Add PostHog support in GoDAM * feat: Add PostHog settings to allow user to disable tracking * fix: Update settings help text Co-authored-by: Copilot <[email protected]> * feat: Update package.json Co-authored-by: Copilot <[email protected]> * fix: Update PostHog setting in Help page, Opt-in methods * feat: Add Admin Notice for usage tracking * fix: Console error on Help page * fix: Update notice message * fix: Make tracking anonymous * fix: PostHog initialization * fix: Enqueue JS for admin notice --------- Co-authored-by: Copilot <[email protected]> * Fix/ios player (#1465) * Fixed Image CTA (Portrait) Cut Off in Safari Instead of Being Responsive * Updated text wrap property for title andd description in image cta * fix: Player controls for minimal skin * fix: Play button vertical alignment * fix: Skip buttons alignment in Default skin * fix: Video loading animation play button on mobile screen * fix: Share button not clickable * fix: Remove outline from video player elements * fix: Make CTA image layer (landscape) responsive * fix: No left padding in control bar for Pills skin * fix: Captions on Safari * fix: Image CTA double container in video editor * fix: Make CTA image layer responsive on inline video * fix: Remove Share button from iOS fullscreen * fix: Seeker overlapping over captions menu * fix: Default Skin play button slightly to the left * fix: CTA title should have ellipsis after exceeding 2 lines * fix: Hover effects for menu in Bubble Skin * fix: Time start and time duration in bubble skin * fix: Time flickering issue in Bubble skin * fix: Hide share button in all fullscreens * fix: Horizontally align play button in classic skin * fix: Improve Vertical Image CTA scroll behaviour * fix: CTA scroll behaviour in portrait mode * fix: Make CTA consistent in video editor and frontend * fix: Remove extra gap in container * fix: Remove unnecessary else if condition * fix: Minial skin play button for desktop * fix: Increase CTA description text size * fix: Keyboard play/pause indicator icon * fix: Undo centering of play button for minimal and pills skins * fix: Center the big play button for both mobile and desktop * fix: Keyboard vjs-play indicator --------- Co-authored-by: opurockey <[email protected]> * Fix: Recorder pop up modal doesn't open for SureForms on preview page. (#1477) * Fix the overlap of godam/video block UI with engagement modal (#1473) Co-authored-by: KMchaudhary <[email protected]> * fix: Make hotspot tooltip visible inside video container always (#1478) * Add hotfix to videojs config for Safari, and iOS device playback (#1479) Co-authored-by: KMchaudhary <[email protected]> * Fix - GoDAM Block in Row and Stack, Block Icon Hover issue (#1501) * fix: Add support for Row and Stack in block editor * fix: Blue hover issue on GoDAM Blocks icons * fix: Add alt text to icon images * Feat/virtual media all (#1412) * Implement virtual media support for audio, image, and PDF blocks * Fix the core/image attempt block recovery issue Create block extension script that will help us extend the core blocks editor logic * Implement image versions callback endpoint * Add subtype=pdf check for pdf attachments * Only show the oEmbed field on medias popup if its video attachment * Add transcoding URL, and virtual status for audio, pdf, and image attachments This will show the correct transcoding status for default and virtual media imported from GoDAM central * Fix the virtual file name, add extension after filename * Fix the icon preview based on file type for virtual attachments * Add support for virtual pdf media thumbnail support * Completed the image subsizes generation, and rendering on frontend for image attachments Remove debug statements * Handle image version generation if all requested versions are already available * Fix the fullsize image's srcset domain mismatch issue * Remove unwanted changes * Resolve copilot feedback * Resolve the second iteration of copilot issues * Fix video thumbnail regresion issue for virtual media * Resolve the PR feedback * Resolve breaking merge conflicts * Update the use of URL validation function --------- Co-authored-by: KMchaudhary <[email protected]> * Started storing the transcoded image url in attachment postmeta (#1505) * Started storing the transcoded image url in attachment postmeta * Resolve copilot comments --------- Co-authored-by: KMchaudhary <[email protected]> * Fix: GoDAM Recorder links are not working as expected for WPForms and Ninja Forms #1182 (#1502) * Fix: GoDAM Recorder links are not working as expected for WPForms and Ninja Forms #1182 * Update inc/classes/ninja-forms/class-ninja-forms-integration.php Co-authored-by: Copilot <[email protected]> * Update inc/classes/ninja-forms/class-ninja-forms-integration.php Co-authored-by: Copilot <[email protected]> * Moved Ninja submission list script to standalone file --------- Co-authored-by: Copilot <[email protected]> * Implement the loading animation on godam_video block (#1500) * Implement the loading animation on godam_video block Show loading animation for first time until videojs player is ready * Resolve copilot comments * fix the style loading issue for some sites --------- Co-authored-by: KMchaudhary <[email protected]> * Show the oEmbed URL for godam tab video items (#1513) * Show the oEmbed URL for godam tab video items * fix the audio, pdf thumbnail url if thumbnail url not recevied from godam-central --------- Co-authored-by: KMchaudhary <[email protected]> * Fix mobile responsiveness for Analytics and Dashboard pages (#1481) * Fix buttons overflow issue * Fix underline issue * Fix graph issue * Adress github bot comments * fix: Analytics page header and text --------- Co-authored-by: Subodh Rajpopat <[email protected]> * Fix - QA skins fixes (#1515) * fix: Volume slider for Bubble skin * fix: Text CTA overflow and Quill Styles * fix: Limit height of VideoJS menus * fix: Close button width on mobile fullscreen * fix: Font Weight * fix: Time Control in bubble skin for Engagements modal * fix: Add space in comment Co-authored-by: Copilot <[email protected]> * fix: Add missing semicolon Co-authored-by: Copilot <[email protected]> * fix: Add horizontal padding to Text CTA * fix: Wrong share button in Bubble Skin --------- Co-authored-by: Copilot <[email protected]> * fix: New PCP errors related to ABSPATH (#1519) * fix: Add possible check for Refresh Status error (#1517) * Fix the image transcoding retranscoding requests (#1520) * Fix the image transcoding retranscoding requests Restrict the retranscoding request for images when virtual media is created * Address typos --------- Co-authored-by: KMchaudhary <[email protected]> * Fix the url missmatch of virtual image source set (#1522) * Fix the url missmatch of virtual image source set * Resolve copilot comments --------- Co-authored-by: KMchaudhary <[email protected]> * Fix the Copy Block button breaking block on editor issue (#1529) Co-authored-by: KMchaudhary <[email protected]> * Fix the gallery block console errors, occure due to rtmedia plugin (#1530) * Fix the gallery block console errors, occure due to rtmedia plugin * Fix github advance security issue: DOM text reinterpreted as HTML --------- Co-authored-by: KMchaudhary <[email protected]> * Fix the email, firstname, lastname 0 value passed to transcoding request (#1538) Co-authored-by: KMchaudhary <[email protected]> * Fix the aspectRatio compatibility issue on godam video block (#1541) Co-authored-by: KMchaudhary <[email protected]> * Release/doc v1.5.0 (#1540) * Replace the doc commetn @SInCE version string n.e.x.t with 1.5.0 * Add changelogs, update versions, and add new contributors profiles * Generate new POT file for release v1.5.0 --------- Co-authored-by: KMchaudhary <[email protected]> * Add new contributors (#1542) * Add new contributors * Add kishu7270 --------- Co-authored-by: KMchaudhary <[email protected]> --------- Co-authored-by: Subodh Rajpopat <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Rockey Opu <[email protected]> Co-authored-by: Shivam Jha <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: subodhr258 <[email protected]> Co-authored-by: KMchaudhary <[email protected]> Co-authored-by: Ahmar Zaidi <[email protected]>
Summary
This PR fixes an issue where the Image CTA (Portrait) was being cut off in Safari instead of scaling responsively. The problem was caused by Safari’s handling of sizing and aspect-ratio behavior, which differed from other modern browsers.
Problem
Solution
Impact
Testing
Issue: #1145