Sync main to develop #990
Closed
Sync main to develop #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add HLS URLs for virtual media * feat: add virtual media HLS support for godam player block * fix: remove duplicate source URL on frontend * fix: update media mime check
* fix: prevent duplicate attachments for virtual media * feat: add transcoded links display for GoDAM tab * fix: update attachment fields display structure * fix: add i18n to all strings * docs: add comments and documentation
Feat/hls support
Add changelog for HLS support for GoDAM Virtual Media
Release 1.3.5
docs: Updated changelog date
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR synchronizes the main branch with the develop branch for version 1.3.5 of the GoDAM WordPress plugin. The update focuses on improving video transcoding functionality and adding HLS streaming support.
- Version bump from 1.3.4 to 1.3.5 across all relevant files
- Enhanced transcoding parameters with author information and public visibility defaults
- Added HLS URL support for GoDAM Virtual Media in the media library and player components
Reviewed Changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| readme.txt | Updated stable tag and added v1.3.5 changelog entry |
| package.json | Version bump to 1.3.5 |
| languages/godam.pot | Updated project version and POT creation date with line number adjustments |
| inc/helpers/custom-functions.php | Added author metadata and public flag to transcoding requests |
| inc/classes/rest-api/class-media-library.php | Added HLS URL and job ID metadata storage |
| inc/classes/class-media-library-ajax.php | Added HLS URL to media item preparation |
| godam.php | Updated plugin version and constant definition |
| assets/src/js/media-library/views/media-frame-select.js | Added HLS URL to media selection data |
| assets/src/js/media-library/views/attachment-details.js | New component for displaying transcoded URLs in media modal |
| assets/src/js/media-library/index.js | Integrated new attachment details component |
| assets/src/blocks/godam-player/edit.js | Enhanced player to support both MPD and HLS sources with validation |
| admin/class-rtgodam-transcoder-handler.php | Added author information and public flag to transcoding handler |
| README.md | Updated stable tag to 1.3.5 |
| CHANGELOG.md | Added v1.3.5 changelog entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+437
to
+438
| $author_last_name = $current_user->last_name; | ||
|
|
There was a problem hiding this comment.
[nitpick] There's an extra blank line between variable assignment and the comment. Consider removing the blank line for consistency with the code style.
Suggested change
| $author_last_name = $current_user->last_name; | |
Comment on lines
+266
to
+267
| $author_last_name = ''; | ||
|
|
There was a problem hiding this comment.
[nitpick] There's an extra blank line between variable initialization and the conditional check. Consider removing the blank line for consistency with the code style.
Suggested change
| $author_last_name = ''; | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.