createArea() updated with new default parameters + tests#215
Merged
berthetclement merged 5 commits intorelease/9.2from Apr 8, 2025
Merged
createArea() updated with new default parameters + tests#215berthetclement merged 5 commits intorelease/9.2from
berthetclement merged 5 commits intorelease/9.2from
Conversation
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- R/createArea.R: Language not supported
- R/removeArea.R: Language not supported
- R/writeHydroValues.R: Language not supported
- man/get_default_hydro_ini_values.Rd: Language not supported
- tests/testthat/test-createArea.R: Language not supported
Comments suppressed due to low confidence (1)
NEWS.md:12
- [nitpick] Consider verifying if the spacing in the new parameter name is intended or if an underscore-separated name (e.g., overflow_spilled_cost_difference) would be more consistent with similar parameter naming conventions in the configuration.
* `createArea()` initializes the `hydro.ini` file with a new parameter `overflow spilled cost difference`
berthetclement
added a commit
that referenced
this pull request
Apr 24, 2025
* initial commit to create the main branch of the release * ST-Storages (#200) * createClusterST() updated to have no restriction on group with version >= 9.1 + tests * createClusterST() / editClusterST() updated to have no restriction with 'group' name for a study >= 9.1 + tests Add .check_group_st() to mutalize this check * clean reference to v9.0 and v9.1 (none official Antares simulator versions). * add antaresRead as dev and remote package dependancies * add vignette 9.2 + build site gh-pages release920/dev * githubactions no deploy on pull request * 9.1/storages (#201) * github actions docs /release920 * 9.1/storages (#202) * fix github actions ... docs/release920 doesn't exist * 9.1/storages (#203) * workflow pkgdown add concurrency + folder docs * 9.1/storages (#204) * workflow update Build site * 9.1/storages (#205) * createClusterST() reforge part to write values and suppress message from fwrite * update news.md with link doc and doc section + update vignette * update workflow pkgdown * 9.1/storages (#206) * github actions add master to pull_request * pkgdown workflow (#207) * pkgdown workflow add branches: [master, release/9.2] * minor updates (#208) * update vignette + workflow pkgdown * workflow pkgdown (#209) * update workflow pkgdown * st-storages : New parameters and Time Series (#210) * createClusterST() updated with new parameters + tests * createClusterST() updated with new optional TS + tests * Mutualize doc roxygen between createClusterST() and editClusterST() + add test for editClusterST() on properties part * createClusterST() add document outline to discribe every step in function + reforge code adding .default_values_st_TS() private function to manage list of default values of TS * generate_cluster_name() add comment, infent * editClusterST() updated with document outline to descibe the steps. Fix prefix part when edit only TS. Add check to TS dimension input. Add new feature to edit optional TS + tests * test file test-createClusterST.R reforged * add new test file for RemoveClusterST * test createCluster updated with prefix test + reforge all test EditCluster for 8.6 and 8.8 * add tests for removeClusterST() from 8.6 to 9.2 * Create/Edit apply case tolower to cluster_name + tests * add tests for removeClusterST() * news.md updated * createClusterST/editClusterST doc + examples updated * add remotes branchs release for antaresRead * createClusterST() add example in doc + vignette updated * add doc definition for new TS parameters (#211) * Ant2929/generaldata (#212) * resync doc * activateRES() minor updates * updateAdequacySettings() display warning 'lifecycle' for parameters removed from Antares 9.2 * update pkgdown site with bootstrap 5 + fix some warnings about vignette * doc built (#213) * Vignette/generaldata (#214) * doc built cr8 cluster-st * update doc storage with unit measure for TS * update vignette with generaldata part * createArea() updated with new default parameters + tests (#215) * createArea() updated with new default parameters + tests * newmd updated with hydraulic part * createStudy() updated with new init parameters + tests * updateOptimizationSettings() updated with new default value * vignette updated * updateScenarioBuilder() updated to use 'hfl' + doc + tests (#216) * updateScenarioBuilder() updated to use 'hfl' + doc + tests * vignette for scenario builder part * Scenariobuilder (#217) * vignette delete "new features" title * delete github remotes antareRead + change destination build site + update github workflow pkgdown * DESCRIPTION add remotes antares (master) + newmd update url of pkgdownsite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update or create parameters for hydraulic part across :
createStudy()createAreavignette updated too