Skip to content

Conversation

@rti
Copy link
Owner

@rti rti commented Feb 1, 2024

TODO

@rti rti requested review from exowanderer February 9, 2024 09:38
Copy link
Collaborator

@exowanderer exowanderer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a lot of comments and suggestions. I promise that they are 95% "PEP8 this" and "format suggestion that".

I will make a new branch with a PR that implements all of my suggestions so that neither of you has to go through them one by one.

The comment list here will be my check list after both of you approve the PR from my integrations_pep8 into the integration branch.

@exowanderer
Copy link
Collaborator

I submited a PR(#24) from the integration_pep8 branch to integration branch.

This PR addresses 95% of my comments and suggestions. They are largely related to PEP8 formatting, my suggest formatting, and creating a logger.py file instead of using print statements

If you review and agree with the PR, as well as merge it, then we can close this review comments.

@rti rti mentioned this pull request Feb 12, 2024
2 tasks
@rti rti merged commit 4100064 into main Feb 27, 2024
@rti rti deleted the integration branch February 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants