Open
Conversation
This is fine as long as the user does not change or disable the cycle counter. It allows the other DWT features to be used freely by the application.
jordens
force-pushed
the
feature/ref-dwt
branch
from
7326c2a to
442fc8c
Compare
AfoHT
reviewed
Feb 6, 2022
* upstream/master: restrict ext pub use Update Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DWT has a lot of other functionality besides the cycle counter that the user can currently not access safely as DwtSystick owns DWT.
Once set up (
new()andreset())DwtSystickonly needs the DWT to read the cycle counter. That could also be done safely without owning the DWT.If we borrow DWT only for cycle counter configuration, the user could keep and use its other functionality afterwards. The downside is that the user would have to manually ensure that they don't disable or reset cycle counter after
reset().On balance this may be acceptable.