Conversation
…e the Medtech Reference Architecture. Add dockerfile scripts which allow for containerization
Integrated Vector CANoe example/demo and created README. Updated examples README
| [submodule "resource/cmake/rticonnextdds-cmake-utils"] | ||
| path = resource/cmake/rticonnextdds-cmake-utils | ||
| url = https://github.com/rticommunity/rticonnextdds-cmake-utils | ||
| [submodule "examples/lss_robot/LSS_Library_Python"] |
There was a problem hiding this comment.
For some reason the submodule didn't get added to the git index (maybe not committed?), so git submodule update --init ... didn't pull in the LSS submodule. I used this to add the submodule locally, but examples/lss_robot/LSS_Library_Python just needs to be committed.
git submodule add -f https://github.com/Lynxmotion/LSS_Library_Python.git examples/lss_robot/LSS_Library_Python
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
There was a problem hiding this comment.
I reformatted the style to align with the modules. I will commit these changes in a doc-only commit.
I added a section on "setup" - this should be reviewed for accuracy.
| [DDS::Writer::Reliability=BEST_EFFORT] | ||
| [DDS::Writer::History=KEEP_ALL] |
There was a problem hiding this comment.
I'm unfamiliar with CANoe vCDL, but BEST_EFFORT + KEEP_ALL doesn't usually make sense. For telemetry data, we may want BEST_EFFORT + KEEP_LAST.
| [DDS::Reader::Reliability=RELIABLE] | ||
| [DDS::Reader::History=KEEP_ALL] |
There was a problem hiding this comment.
We should be using RELIABLE + KEEP_LAST if we want to align with the DataFlowLibrary::Command qos used for t/MotorControl elsewhere.
| [DDS::Reader::Reliability=RELIABLE] | ||
| [DDS::Reader::History=KEEP_ALL] |
There was a problem hiding this comment.
We should be using RELIABLE + KEEP_LAST if we want to align with the DataFlowLibrary::Command qos used for t/MotorControl elsewhere.
wcoleman-rti
left a comment
wcoleman-rti
left a comment
There was a problem hiding this comment.
@ajmhs I made a first pass review. Mostly doc styling changes to the readmes, but a few minor tweaks to variables/config to get things running on my machine.
Please review the suggestions I made and if they're valuable to include, or would break your setup for demoing purposes (in which case we should more clearly document setup expectations and exceptions).
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
Co-authored-by: wcoleman-rti <108848592+wcoleman-rti@users.noreply.github.com>
… POSIX compliant option
…g demo. Updated xbox & joystick controllers, and telemetry bridge app for commonality.
2 participants
Additions of examples and dockerfiles to the main codebase of the Reference Architecture as discussed.