feat: infer pnpm bare scripts through run#1540
Open
artile wants to merge 2 commits intortk-ai:developfrom
Open
feat: infer pnpm bare scripts through run#1540artile wants to merge 2 commits intortk-ai:developfrom
artile wants to merge 2 commits intortk-ai:developfrom
Conversation
Collaborator
📊 Automated PR Analysis
SummaryAdds automatic Review Checklist
Analyzed automatically by wshm · This is an automated analysis, not a human review. |
Make rtk pnpm route bare script names through pnpm run while keeping specialized pnpm commands and hook rewrites intact. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Keep pnpm global filter flags before the injected run subcommand so filtered workspace script execution matches native pnpm semantics. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
93a899f to
942c653
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rtk pnpm <script>inferpnpm run <script>for bare script names while keeping specialized pnpm commands unchangedrunsubcommand for workspace-filtered scriptsTest plan
rtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_pnpm_subcommand_routingrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_pnpm_run_args_preserve_global_filtersrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_filter_pnpm_script_outputrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_rewrite_pnpm_commandrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_rewrite_compound_pnpm_and_gitrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml test_normalize_hook_check_command_shell_wrapperrtk cargo build --manifest-path /root/TAO/Tools/rtk/Cargo.tomlrtk cargo clippy --manifest-path /root/TAO/Tools/rtk/Cargo.toml --all-targetsrtk cargo test --manifest-path /root/TAO/Tools/rtk/Cargo.toml --allrtk cargo run --manifest-path /root/TAO/Tools/rtk/Cargo.toml -- rewrite pnpm buildrtk cargo run --manifest-path /root/TAO/Tools/rtk/Cargo.toml -- rewrite pnpm test:coveragertk cargo run --manifest-path /root/TAO/Tools/rtk/Cargo.toml -- hook check bash \"pnpm build\"/root/TAO/Tools/rtk/target/debug/rtk pnpm buildfrom/root/TAO/Projects/MyRemotely/web-app/root/TAO/Tools/rtk/target/debug/rtk -v pnpm --filter @app/web buildconfirms native shapepnpm --filter=@app/web run build🤖 Generated with Claude Code