feat(telemetry): respect DO_NOT_TRACK environment variable#1543
Open
CtriXin wants to merge 1 commit intortk-ai:masterfrom
Open
feat(telemetry): respect DO_NOT_TRACK environment variable#1543CtriXin wants to merge 1 commit intortk-ai:masterfrom
CtriXin wants to merge 1 commit intortk-ai:masterfrom
Conversation
`DO_NOT_TRACK=1` or `DO_NOT_TRACK=true` now opts out of telemetry, matching the standard env var convention used by many tools. Fixes: rtk-ai#1514
|
|
Collaborator
📊 Automated PR Analysis
SummaryAdds support for the standard DO_NOT_TRACK environment variable to opt out of telemetry. When DO_NOT_TRACK is set to "1" or "true" (case-insensitive), telemetry pings are suppressed, checked right after the existing RTK_TELEMETRY_DISABLED guard. Review Checklist
Linked issues: #1514 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DO_NOT_TRACK=1orDO_NOT_TRACK=truenow opts out of telemetry, matching the standard env var convention.Change: added check in
maybe_ping()after the existingRTK_TELEMETRY_DISABLEDcheck.Fixes: #1514
Test Plan
cargo test telemetry— 16 tests passDO_NOT_TRACK=1 rtk gainproduces no telemetry ping