Skip to content

feat(telemetry): respect DO_NOT_TRACK environment variable#1543

Open
CtriXin wants to merge 1 commit intortk-ai:masterfrom
CtriXin:fix/issue-1514-do-not-track
Open

feat(telemetry): respect DO_NOT_TRACK environment variable#1543
CtriXin wants to merge 1 commit intortk-ai:masterfrom
CtriXin:fix/issue-1514-do-not-track

Conversation

@CtriXin
Copy link
Copy Markdown

@CtriXin CtriXin commented Apr 26, 2026

Summary

DO_NOT_TRACK=1 or DO_NOT_TRACK=true now opts out of telemetry, matching the standard env var convention.

Change: added check in maybe_ping() after the existing RTK_TELEMETRY_DISABLED check.

Fixes: #1514

Test Plan

  • cargo test telemetry — 16 tests pass
  • Manual: DO_NOT_TRACK=1 rtk gain produces no telemetry ping

`DO_NOT_TRACK=1` or `DO_NOT_TRACK=true` now opts out of telemetry,
matching the standard env var convention used by many tools.

Fixes: rtk-ai#1514
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pszymkowiak pszymkowiak added effort-small Quelques heures, 1 fichier enhancement New feature or request good first issue Good for newcomers labels Apr 26, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

Type feature
🟢 Risk low

Summary

Adds support for the standard DO_NOT_TRACK environment variable to opt out of telemetry. When DO_NOT_TRACK is set to "1" or "true" (case-insensitive), telemetry pings are suppressed, checked right after the existing RTK_TELEMETRY_DISABLED guard.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #1514


Analyzed automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort-small Quelques heures, 1 fichier enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Respect DO_NOT_TRACK environment variable

4 participants