fix(config): add #[serde(default)] to partial config sections#1544
Open
CtriXin wants to merge 1 commit intortk-ai:masterfrom
Open
fix(config): add #[serde(default)] to partial config sections#1544CtriXin wants to merge 1 commit intortk-ai:masterfrom
CtriXin wants to merge 1 commit intortk-ai:masterfrom
Conversation
Partial TOML sections like `[limits]` now parse correctly when only some fields are specified. Without #[serde(default)], missing fields caused a parse error that silently discarded the entire section. Added #[serde(default)] to: TrackingConfig, DisplayConfig, FilterConfig, TelemetryConfig, LimitsConfig. Fixes: rtk-ai#1482
|
|
Collaborator
📊 Automated PR Analysis
SummaryAdds Review Checklist
Linked issues: #1482 Analyzed automatically by wshm · This is an automated analysis, not a human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Partial TOML config sections like
[limits]now parse correctly when only some fields are specified.Root cause: Without
#[serde(default)], missing fields in a TOML section causetoml::from_strto return amissing fielderror. This bubbles up toConfig::load(), which silently falls back to full defaults — discarding every user-specified override.Fix: Added
#[serde(default)]to five sub-config structs:TrackingConfig,DisplayConfig,FilterConfig,TelemetryConfig,LimitsConfig. Each already implementsDefaultwith correct values, so serde now falls back to those defaults for any missing fields.Fixes: #1482
Test Plan
cargo test config— 14 tests pass[limits]with onlygrep_max_results = 500applies correctly