Skip to content

fix(stream): passthrough watch commands#1547

Open
nkootstra wants to merge 2 commits intortk-ai:developfrom
nkootstra:fix/streaming-watch-passthrough-develop
Open

fix(stream): passthrough watch commands#1547
nkootstra wants to merge 2 commits intortk-ai:developfrom
nkootstra:fix/streaming-watch-passthrough-develop

Conversation

@nkootstra
Copy link
Copy Markdown

@nkootstra nkootstra commented Apr 26, 2026

Summary

Fixes watch/dev-style commands that previously looked like they were streaming but still buffered through RTK filtering paths until the child process exited.

This routes known long-running invocations through passthrough execution so stdout/stderr stay attached to the terminal, while still keeping normal filtered commands on the existing buffered/streaming pipeline. It also updates unsupported go and dotnet passthrough paths to actually stream instead of capturing via .output().

Changes

  • Detect watch/dev/follow/codegen-style invocations centrally before applying filtered execution.
  • Preserve gh pr checks --watch detection when extra args are present.
  • Stream interactive Playwright, unsupported Go, and unsupported Dotnet passthrough routes instead of buffering them.
  • Include small clippy cleanups required by the current develop branch.

Verification

  • smll cargo fmt --all
  • smll cargo clippy --all-targets
  • smll cargo test --all (1691p 0f)

Closes #1545

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 26, 2026

CLA assistant check
All committers have signed the CLA.

@pszymkowiak pszymkowiak added bug Something isn't working effort-medium 1-2 jours, quelques fichiers filter-quality Filter produces incorrect/truncated signal labels Apr 26, 2026
@pszymkowiak
Copy link
Copy Markdown
Collaborator

[w] wshm · Automated triage by AI

📊 Automated PR Analysis

🐛 Type bug-fix
🟡 Risk medium

Summary

Fixes watch/dev-style commands (e.g. --watch, dev, serve, codegen) that were being buffered through RTK's filtered execution pipeline instead of streaming directly to the terminal. Adds centralized detection of long-running/streaming invocations in the runner module and routes them through passthrough execution, while also converting unsupported Go and Dotnet passthrough paths from buffered capture to proper streaming.

Review Checklist

  • Tests present
  • Breaking change
  • Docs updated

Linked issues: #1545


Analyzed automatically by wshm · This is an automated analysis, not a human review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working effort-medium 1-2 jours, quelques fichiers filter-quality Filter produces incorrect/truncated signal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants