Open
Conversation
rtlopez
requested changes
Jan 28, 2026
| Hal::Gpio::digitalWrite(_model.config.pin[PIN_BUZZER], (pin_status_t)_model.config.buzzer.inverted); | ||
| break; | ||
| case 1: | ||
| ledc_timer_config_t ledc_timer = { |
Owner
There was a problem hiding this comment.
You shouldn't use hardware specific api here. In this case RP2350 and RP2040 build is broken. It should be hidden behind some generic HAL, or gated by specific ifdef macro, like ESPFC_ADC_0 for example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I made this code to support passive buzzers.
Code was tested. Everything is working properly, buzzer doesn't make any unusual sounds.