Add linux-native-basic-udev feature
#167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid having to rely on libudev, which makes this crate difficult to cross-compile. Instead, traverse `/sys` directly to discover what it is we need. Signed-off-by: Sean Cross <[email protected]>
xobs
force-pushed
the
add-basic-udev-option
branch
2 times, most recently
from
54732a2 to
ada8041
Compare
ruabmbua
reviewed
Mar 15, 2025
Owner
ruabmbua
left a comment
ruabmbua
left a comment
There was a problem hiding this comment.
Thanks for working on this. If you want I can make small fixes myself after merging, or you can do it yourself.
Add an alternative to `libudev-sys` that doesn't require pkgconfig. This allows for cross-compiling to Linux without first obtaining a sysroot for the target. It also allows for compiling to musl, and statically-linking projects that use hidapi. Signed-off-by: Sean Cross <[email protected]>
xobs
force-pushed
the
add-basic-udev-option
branch
from
ada8041 to
1310a6b
Compare
Build linux-native-basic-udev as part of CI. Build it on both Linux native, as well as on Windows to verify that cross-compiling works. Signed-off-by: Sean Cross <[email protected]>
xobs
force-pushed
the
add-basic-udev-option
branch
from
1310a6b to
7c67945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new feature,
linux-native-basic-udev. This is identical tolinux-nativebut usesbasic-udevas a udev source rather thanudev-rs.basic-udev is a reimplementation of just enough udev functionality to support device discovery on most common platforms without needing to link libudev.so.
As a result, it becomes possible to cross-compile crates that depend on
hidapi-rsto Linux (both GNU and Musl) without needing a full sysroot. This greatly simplifies cross-compiling to multiple target architectures, particularly when using cargo-zigbuild.