Upgrade dependencies, in particular windows-sys to 0.61 and nix to 0.30
#179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Bump CC @ruabmbua |
Owner
|
Hey, sry for forgetting about this pr. regarding the new dependency, it would probably be better to try adding the missing extern function to windows-sys? we can temporarily add the extern directly to this crate until it’s in windows-sys. I do not want to depend on a new crate for one missing extern function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of
cargo upgrade --incompatible --pinned --ignore-rust-version --recursiveand manual modifications to account for the changes in the upstream crates.windows-sys0.61.x is very important for me, because it consistently usesraw-dylibfor importing APIs from Windows DLLs. This makes a huge difference when using non-MSVC toolchains to build Windows binaries, e.g.x86_64-pc-windows-gnullvm.Unfortunately,
Win32_Storage_EnhancedStorageis only available in the heavyweightwindowscrate these days, which is why I also need to import that one. However, I'm only importing it for that one feature and continue to usewindows-sysfor the rest of the code.CC @ruabmbua