Skip to content

log warning if secret is not found #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

log warning if secret is not found #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions rubberduckvba.Server/WebhookSignatureValidationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace rubberduckvba.Server;

public class WebhookSignatureValidationService(ConfigurationOptions configuration)
public class WebhookSignatureValidationService(ConfigurationOptions configuration, ILogger<WebhookSignatureValidationService> logger)
{
public bool Validate(
string payload,
Expand Down Expand Up @@ -64,8 +64,13 @@ private bool IsValidSignature(string? signature, string payload)
}

var secret = configuration.GitHubOptions.Value.WebhookToken;
var secretBytes = Encoding.UTF8.GetBytes(secret);
if (string.IsNullOrWhiteSpace(secret))
{
logger.LogWarning("Webhook secret was not found; signature will not be validated.");
return false;
}

var secretBytes = Encoding.UTF8.GetBytes(secret);
var payloadBytes = Encoding.UTF8.GetBytes(JsonConvert.SerializeObject(JsonConvert.DeserializeObject(payload)));

using var digest = new HMACSHA256(secretBytes);
Expand Down