Skip to content

Fix github download timing +CORS issues #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix github download timing +CORS issues #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...erduckvba.Server/ContentSynchronization/Pipeline/Sections/SyncTags/LoadGitHubTagsBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace rubberduckvba.Server.ContentSynchronization.Pipeline.Sections.SyncTags;

public class LoadGitHubTagsBlock : TransformBlockBase<SyncRequestParameters, SyncContext, SyncContext>
public class LoadGitHubTagsBlock : TransformBlockBase<SyncContext, SyncContext, SyncContext>
{
private readonly IGitHubClientService _github;

Expand All @@ -14,7 +14,7 @@ public LoadGitHubTagsBlock(PipelineSection<SyncContext> parent, CancellationToke
_github = github;
}

public override async Task<SyncContext> TransformAsync(SyncRequestParameters input)
public override async Task<SyncContext> TransformAsync(SyncContext input)
{
var githubTags = await _github.GetAllTagsAsync(Context.RubberduckDbMain.Name);
var (gitHubMain, gitHubNext, gitHubOthers) = githubTags.GetLatestTags();
Expand Down
2 changes: 1 addition & 1 deletion rubberduckvba.Server/ContentSynchronization/Pipeline/Sections/SyncTags/SyncTagsSection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public override void CreateBlocks()
AcquireDbNextTag.CreateBlock(BroadcastParameters);
JoinDbTags.CreateBlock(AcquireDbMainTag, AcquireDbNextTag);
LoadDbTags.CreateBlock(JoinDbTags);
LoadGitHubTags.CreateBlock(BroadcastParameters);
LoadGitHubTags.CreateBlock(LoadDbTags);
JoinTags.CreateBlock(LoadDbTags, LoadGitHubTags);
BroadcastTags.CreateBlock(JoinTags);
StreamGitHubTags.CreateBlock(BroadcastTags);
Expand Down
4 changes: 3 additions & 1 deletion rubberduckvba.Server/RubberduckApiController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
using Microsoft.AspNetCore.Mvc;
using Microsoft.AspNetCore.Cors;
using Microsoft.AspNetCore.Mvc;
using rubberduckvba.Server;
using System.Diagnostics;
using System.Runtime.CompilerServices;

namespace rubberduckvba.Server;

[ApiController]
[EnableCors("CorsPolicy")]
public abstract class RubberduckApiController : ControllerBase
{
private readonly ILogger _logger;
Expand Down