Telegrambost springboot mapping starter#1493
Open
taragrammatonn wants to merge 20 commits intorubenlagus:devfrom
Open
Telegrambost springboot mapping starter#1493taragrammatonn wants to merge 20 commits intorubenlagus:devfrom
taragrammatonn wants to merge 20 commits intorubenlagus:devfrom
Conversation
…agus#1482) Co-authored-by: Ruben Bermudez <rubenlagus@users.noreply.github.com>
…1475) Co-authored-by: Ruben Bermudez <rubenlagus@users.noreply.github.com>
Fixed brackets on javadoc to show properly Co-authored-by: Ruben Bermudez <rubenlagus@users.noreply.github.com>
yvasyliev
suggested changes
Jun 20, 2025
yvasyliev
left a comment
yvasyliev
left a comment
There was a problem hiding this comment.
If the whole change is about Bot Command mapping, I would name the module and related classes more specifically (e.g. telegrambots-springboot-longpolling-command-starter)
Comment on lines
+30
to
+34
| @Bean | ||
| @ConditionalOnMissingBean | ||
| public OkHttpClient okHttpClient() { | ||
| return new OkHttpClient(); | ||
| } |
There was a problem hiding this comment.
Why is OkHttpClient bean created but never used?
| } | ||
|
|
||
| @Bean | ||
| public SpringLongPollingBot springLongPollingBot(TelegramBotProperties properties, |
There was a problem hiding this comment.
I would add @ConditionalOnMissingBean for extension opportunity
Comment on lines
+52
to
+64
| @Bean | ||
| @ConditionalOnMissingBean(TelegramBotsLongPollingApplication.class) | ||
| public TelegramBotsLongPollingApplication telegramBotsApplication() { | ||
| return new TelegramBotsLongPollingApplication(); | ||
| } | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean | ||
| public TelegramBotInitializer telegramBotInitializer(TelegramBotsLongPollingApplication telegramBotsApplication, | ||
| ObjectProvider<List<SpringLongPollingBot>> longPollingBots) { | ||
| return new TelegramBotInitializer(telegramBotsApplication, | ||
| longPollingBots.getIfAvailable(Collections::emptyList)); | ||
| } |
There was a problem hiding this comment.
Since telegrambots-springboot-longpolling-starter is transitively included into into telegrambost-springboot-mapping-starter, no need to define TelegramBotsLongPollingApplication & TelegramBotInitializer beans explicitly
Comment on lines
+26
to
+29
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
spring-boot-starter dependency is redundant in this module
There was a problem hiding this comment.
- Missing
valueattribute. - I believe the alias should be
commandsinstead ofcommand.
| BotRequestMapping annotation = AnnotationUtils.findAnnotation(method, BotRequestMapping.class); | ||
| if (annotation != null) { | ||
| for (String command : annotation.value()) { | ||
| handlers.put(command, new BotHandlerMethod(bean, method)); |
There was a problem hiding this comment.
Should we check if a method has exactly one parameter of Update?
There was a problem hiding this comment.
Please remove unused/duplicated imports
| } | ||
|
|
||
| public void handleUpdate(Update update) { | ||
| if (update.hasMessage() && update.getMessage().hasText()) { |
| <version>8.2.0</version> | ||
| </parent> | ||
|
|
||
| <artifactId>telegrambost-springboot-mapping-starter</artifactId> |
rubenlagus
force-pushed
the
dev
branch
3 times, most recently
from
52a184e to
9203912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.