38 feat add support for co relrec relspec relsub domains#284
Merged
rubentalstra merged 4 commits intomainfrom Jan 26, 2026
Merged
Conversation
…dated snapshots and export logic
…r logic and UI integration
6 tasks
…ource-mapped structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the codebase to consistently restrict mapping, preview, validation, and supplemental configuration logic to only operate on "source domains." It introduces explicit checks and conversions to ensure that these operations are not mistakenly applied to generated or non-source domains, improving correctness and maintainability. Additionally, it updates project persistence logic to only serialize source domains, preparing the codebase for future handling of generated domains.
Domain Handling Consistency
domain_editor.rsto operate only on source domains by adding explicit.as_source()or.as_source_mut()checks, preventing unintended operations on other domain types. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Project Persistence Updates
project.rsto only persist file-based data (snapshots and assignments) for source domains, skipping generated domains and setting up for future extensibility.Validation and Mapping State Management
invalidate_validation()with direct manipulation of thevalidation_cachefield for source domains, simplifying the cache invalidation process. [1] [2] [3] [4] [5] [6] [7] [8]Export Logic Restriction
Codebase Cleanup
project.rsto support the newSourceDomainSnapshotand related structures.