Merged
Conversation
…istency in empty states
…proving destructuring
…Validation, Normalization, and Mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the dialog management system and UI components in the
tss-guicrate. The most significant change is the migration from thedialog_windowsstructure to a unifieddialog_registryfor managing dialog state, which simplifies dialog handling and improves maintainability. Additionally, the PR includes various UI component cleanups, such as removing unnecessary clones, using pattern destructuring, and improving code clarity.Dialog Management Refactor:
dialog_windowssystem with a newdialog_registryfor unified dialog state management. All dialog-related operations (opening, closing, updating state, and querying dialog type) now usedialog_registry, resulting in cleaner and more maintainable code. [1] [2] [3] [4] [5] [6]UI Component Cleanups and Improvements:
ActionButton,SelectableRow,data_table,domain_badge, etc.) to use pattern destructuring instead of field clones, reducing unnecessary allocations and improving code clarity. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]ActionButtonStylederiveCopyto enable more ergonomic usage.Minor API & Style Updates:
.with_badge()to.badge()for consistency.ALPHA_LIGHTconstant for consistency across the theme. [1] [2]These changes collectively modernize the dialog state handling and improve the maintainability and performance of UI components.