Skip to content

[WIP] Update Secp256k1Keypair verify method implementation#3

Closed
Copilot wants to merge 1 commit intoarnab/secp256k1-verify-methodfrom
copilot/sub-pr-2
Closed

[WIP] Update Secp256k1Keypair verify method implementation#3
Copilot wants to merge 1 commit intoarnab/secp256k1-verify-methodfrom
copilot/sub-pr-2

Conversation

Copy link

Copilot AI commented Nov 12, 2025

Thanks for the feedback on #2. I've created this new PR, which merges into #2, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #2
Triggering review: #2 (comment)

@copilot This is done due to library limitation of ecpy which expects a Point value in the ECPublicKey. While that is possible to be done, but it increases the risk of validation, and hence its better to go with the current implementation of deriving the public key from private key which is safe.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants