[Fix #368] Add DelegatePrivate cop#1057
Open
povilasjurcys wants to merge 1 commit intorubocop:masterfrom
Open
Conversation
3362967 to
72401e5
Compare
72401e5 to
6958079
Compare
koic
reviewed
Feb 26, 2025
| expect_offense(<<~RUBY) | ||
| class User | ||
| delegate :name, to: :user, private: true | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ private `delegate` should be put in private section |
Member
There was a problem hiding this comment.
It seems that layout issues and functional issues are mixed together. By focusing solely on functionality, this cop's purpose and role become simpler, so allowing this case would be preferable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #368 issue by adding DelegatePrivate cop. This cop ensures that
private: trueis used when delegating methods in private is skipped in public scope. Here are more cases:Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.