Add new Rails/AssertChangesSecondArgument cop#1401
Open
joseph-carino wants to merge 2 commits intorubocop:masterfrom
Open
Add new Rails/AssertChangesSecondArgument cop#1401joseph-carino wants to merge 2 commits intorubocop:masterfrom
Rails/AssertChangesSecondArgument cop#1401joseph-carino wants to merge 2 commits intorubocop:masterfrom
Conversation
04115f4 to
e6af276
Compare
nvasilevski
reviewed
Jan 9, 2025
e6af276 to
6dad261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1396
Adds new cop for
assert_changes, preventing its usage with a non-string, non-symbol second argument. This avoid accidental use ofassert_changeswith an expected value delta check.Includes an autocorrect that replaces
assert_changeswithassert_difference, which does accept a second argument value delta check.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.