Handle recursive keys in strong parameters expect#1430
Open
chaadow wants to merge 1 commit intorubocop:masterfrom
Open
Handle recursive keys in strong parameters expect#1430chaadow wants to merge 1 commit intorubocop:masterfrom
chaadow wants to merge 1 commit intorubocop:masterfrom
Conversation
chaadow
commented
Jan 26, 2025
chaadow
force-pushed
the
fix_expect_param_recursive
branch
2 times, most recently
from
2af9715 to
1b8d885
Compare
chaadow
commented
Jan 26, 2025
| user: [:name, # comment | ||
| :age] # comment | ||
| ) | ||
| user: [:name, :age]) |
Author
There was a problem hiding this comment.
Could not find a solution to preserve comments when autocorrecting in a recursive fashion
Fixes rubocop#1429 Use a recursive approach to autocorrect nested parameters - Top level hash keys do not get replaced by `[]` - Hash values that are hashes get replaced by `[]` - Arrays get replaced by double brackets `[[]]`
chaadow
force-pushed
the
fix_expect_param_recursive
branch
from
1b8d885 to
7e12bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1429
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.