Skip to content

[Fix #1488] Fix an error for Rails/ReadWriteAttribute cop #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Aug 12, 2025

Resolves #1488

Basically we should not assume AST literals are not frozen.

Replace this text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Resolves rubocop#1488

Basically we should not assume AST literals are not frozen.
@koic koic merged commit f178f30 into rubocop:master Aug 13, 2025
16 checks passed
@koic
Copy link
Member

koic commented Aug 13, 2025

Thanks!

@viralpraxis viralpraxis deleted the fix-rails-read-write-attribute-frozen-string-mutation branch August 13, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rubocop fails when using the Rails/ReadWriteAttribute cop
2 participants