[Fix #1539] Fix an error for Rails/ActionControllerFlashBeforeRender

changelog/fix_an_error_for_rails_action_controller_flash_before_render.md

@@ -0,0 +1 @@
+* [#1539](https://github.com/rubocop/rubocop-rails/issues/1539): Fix an error in `Rails/ActionControllerFlashBeforeRender` when `flash` is used inside a block followed by method chaining. ([@koic][])

lib/rubocop/cop/rails/action_controller_flash_before_render.rb

@@ -98,7 +98,9 @@ def instance_method_or_block?(node)
         end
 
         def use_redirect_to?(context)
-          context.right_siblings.compact.any? do |sibling|
+          context.right_siblings.any? do |sibling|
+            next unless sibling.is_a?(AST::Node)
+
             # Unwrap `return redirect_to :index`
             sibling = sibling.children.first if sibling.return_type? && sibling.children.one?
             sibling.send_type? && sibling.method?(:redirect_to)

spec/rubocop/cop/rails/action_controller_flash_before_render_spec.rb

@@ -427,4 +427,16 @@ def create
       RUBY
     end
   end
+
+  context 'when `flash` is used inside a block followed by method chaining' do
+    it 'does not register an offense and corrects' do
+      expect_no_offenses(<<~RUBY)
+        class NonController < ApplicationRecord
+          before_action do
+            flash[:notice] = 'hello'
+          end.do_something
+        end
+      RUBY
+    end
+  end
 end