Fix glob pattern for Includes and Exclude#1548
Draft
malmckay wants to merge 1 commit intorubocop:masterfrom
Draft
Fix glob pattern for Includes and Exclude#1548malmckay wants to merge 1 commit intorubocop:masterfrom
malmckay wants to merge 1 commit intorubocop:masterfrom
Conversation
269ff59 to
0b0c170
Compare
We had **/, to support directories nested within engines or packwerk dirs This also matched against directory names outside the project Adding ../ scopes the glob to the project directory
0b0c170 to
55f5aa0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had
**/, to support directories nested within engines or packwerk dirs This also matched against directory names above the project Adding../scopes the glob to the project directory, and making the whole../**/optional supports relative paths.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.