Skip to content

Make Rails/StrongParametersExpect allow presence #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
koic wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Make Rails/StrongParametersExpect allow presence #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/rubocop/cop/rails/strong_parameters_expect.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class StrongParametersExpect < Base

MSG = 'Use `%<prefer>s` instead.'
RESTRICT_ON_SEND = %i[[] require permit].freeze
PRESENCE_CHECK_METHODS = %i[nil? blank? present?].freeze
PRESENCE_CHECK_METHODS = %i[nil? blank? present? presence].freeze
RAISING_FINDER_METHODS = %i[find find_by! find_sole_by].freeze

minimum_target_rails_version 8.0
Expand Down
6 changes: 6 additions & 0 deletions spec/rubocop/cop/rails/strong_parameters_expect_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,12 @@
RUBY
end

it 'does not register an offense when using `params[:key].presence`' do
expect_no_offenses(<<~RUBY)
params[:key].presence || default
RUBY
end

it 'registers an offense when using `Model.find(params[:id])`' do
expect_offense(<<~RUBY)
Model.find(params[:id])
Expand Down