Fix incorrect plugin version when displaing rubocop -V#59
Merged
koic merged 1 commit intorubocop:masterfrom Feb 16, 2025
Merged
Fix incorrect plugin version when displaing rubocop -V#59koic merged 1 commit intorubocop:masterfrom
rubocop -V#59koic merged 1 commit intorubocop:masterfrom
Conversation
This commit fixes incorrect plugin version when displaing `rubocop -V`. ## Before The RuboCop core version is displayed incorrectly for `rubocop-rake`: ```console $ bundle exec rubocop -V 1.72.1 (using Parser 3.3.6.0, rubocop-ast 1.38.0, analyzing as Ruby 3.4, running on ruby 3.4.1) [x86_64-darwin23] - rubocop-rake 1.72.1 ``` ## After The correct `rubocop-rake` version is displayed: ```console $ bundle exec rubocop -V 1.72.1 (using Parser 3.3.6.0, rubocop-ast 1.38.0, analyzing as Ruby 3.4, running on ruby 3.4.1) [x86_64-darwin23] - rubocop-rake 0.7.0 ```
koic
force-pushed
the
fix_incorrect_plugin_version
branch
from
8ec0d75 to
d429b81
Compare
koic
added a commit
to rubocop/rubocop
that referenced
this pull request
Feb 16, 2025
When created with `bundle gem`, `version.rb` initially uses `VERSION`. Using `Version::STRING` as an example could lead to mistakes like the following: rubocop/rubocop-rake#59 While it differs slightly from the actual `rubocop-performance`, the example is updated to prioritize preventing such mistakes over strict synchronization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes incorrect plugin version when displaing
rubocop -V.Before
The RuboCop core version is displayed incorrectly for
rubocop-rake:After
The correct
rubocop-rakeversion is displayed: