Merge pull request #1293 from kuboon/patch-1

Better explanation for MessageSpies

Author: pirj

docs/modules/ROOT/pages/cops_rspec.adoc

@@ -2683,8 +2683,11 @@ This cop can be configured in your configuration using the
 ----
 # bad
 expect(foo).to receive(:bar)
+do_something
 
 # good
+allow(foo).to receive(:bar) # or use instance_spy
+do_something
 expect(foo).to have_received(:bar)
 ----
 
@@ -2693,10 +2696,13 @@ expect(foo).to have_received(:bar)
 [source,ruby]
 ----
 # bad
+allow(foo).to receive(:bar)
+do_something
 expect(foo).to have_received(:bar)
 
 # good
 expect(foo).to receive(:bar)
+do_something
 ----
 
 === Configurable attributes

lib/rubocop/cop/rspec/message_spies.rb

@@ -12,17 +12,23 @@ module RSpec
       #
       #   # bad
       #   expect(foo).to receive(:bar)
+      #   do_something
       #
       #   # good
+      #   allow(foo).to receive(:bar) # or use instance_spy
+      #   do_something
       #   expect(foo).to have_received(:bar)
       #
       # @example `EnforcedStyle: receive`
       #
       #   # bad
+      #   allow(foo).to receive(:bar)
+      #   do_something
       #   expect(foo).to have_received(:bar)
       #
       #   # good
       #   expect(foo).to receive(:bar)
+      #   do_something
       #
       class MessageSpies < Base
         include ConfigurableEnforcedStyle