Merge pull request #970 from rubocop-hq/rubocop-performance

Use rubocop-performance

Author: bquorning

.rubocop.yml

@@ -1,5 +1,7 @@
 inherit_from: .rubocop_todo.yml
+
 require:
+ - rubocop-performance
  - rubocop-rspec
  - rubocop/cop/internal_affairs
 

lib/rubocop/cop/rspec/cop.rb

@@ -41,7 +41,7 @@ def relevant_file?(file)
         private
 
         def relevant_rubocop_rspec_file?(file)
-          rspec_pattern =~ file
+          rspec_pattern.match?(file)
         end
 
         def rspec_pattern

lib/rubocop/cop/rspec/describe_class.rb

@@ -64,7 +64,7 @@ def on_top_level_describe(node, (described_value, _))
 
         def string_constant_describe?(described_value)
           described_value.str_type? &&
-            described_value.value =~ /^((::)?[A-Z]\w*)+$/
+            described_value.value.match?(/^(?:(?:::)?[A-Z]\w*)+$/)
         end
       end
     end

lib/rubocop/cop/rspec/empty_line_after_final_let.rb

@@ -25,11 +25,11 @@ class EmptyLineAfterFinalLet < Cop
         def on_block(node)
           return unless example_group_with_body?(node)
 
-          latest_let = node.body.child_nodes.select { |child| let?(child) }.last
+          final_let = node.body.child_nodes.reverse.find { |child| let?(child) }
 
-          return if latest_let.nil?
+          return if final_let.nil?
 
-          missing_separating_line_offense(latest_let) do |method|
+          missing_separating_line_offense(final_let) do |method|
             format(MSG, let: method)
           end
         end

lib/rubocop/cop/rspec/example_wording.rb

@@ -47,9 +47,9 @@ class ExampleWording < Cop
 
         def on_block(node)
           it_description(node) do |description_node, message|
-            if message =~ SHOULD_PREFIX
+            if message.match?(SHOULD_PREFIX)
               add_wording_offense(description_node, MSG_SHOULD)
-            elsif message =~ IT_PREFIX
+            elsif message.match?(IT_PREFIX)
               add_wording_offense(description_node, MSG_IT)
             end
           end
@@ -77,7 +77,7 @@ def docstring(node)
         def replacement_text(node)
           text = text(node)
 
-          if text =~ SHOULD_PREFIX
+          if text.match?(SHOULD_PREFIX)
             RuboCop::RSpec::Wording.new(
               text,
               ignore:  ignored_words,

rubocop-rspec.gemspec

@@ -41,6 +41,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rack'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '>= 3.4'
+  spec.add_development_dependency 'rubocop-performance', '~> 1.7'
   # Workaround for cc-test-reporter with SimpleCov 0.18.
   # Stop upgrading SimpleCov until the following issue will be resolved.
   # https://github.com/codeclimate/test-reporter/issues/418