Fix an error for RSpec/Rails/HaveHttpStatus with comparison with strings containing non-numeric characters

Fix: #1623

Author: ydah

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## Master (Unreleased)
 
 - Fix a false positive in `RSpec/IndexedLet` with suffixes after index-like numbers. ([@pirj])
+- Fix an error for `RSpec/Rails/HaveHttpStatus` with comparison with strings containing non-numeric characters. ([@ydah])
 
 ## 2.20.0 (2023-04-18)
 

lib/rubocop/cop/rspec/rails/have_http_status.rb

@@ -18,7 +18,7 @@ class HaveHttpStatus < ::RuboCop::Cop::Base
           extend AutoCorrector
 
           MSG =
-            'Prefer `expect(response).%<to>s have_http_status(%<status>i)` ' \
+            'Prefer `expect(response).%<to>s have_http_status(%<status>s)` ' \
             'over `%<bad_code>s`.'
 
           RUNNERS = %i[to to_not not_to].to_set
@@ -37,12 +37,14 @@ class HaveHttpStatus < ::RuboCop::Cop::Base
 
           def on_send(node)
             match_status(node) do |response_status, to, match, status|
+              return unless status.to_s.match?(/\A\d+\z/)
+
               message = format(MSG, to: to, status: status,
                                     bad_code: node.source)
               add_offense(node, message: message) do |corrector|
                 corrector.replace(response_status, 'response')
                 corrector.replace(match.loc.selector, 'have_http_status')
-                corrector.replace(match.first_argument, status.to_i.to_s)
+                corrector.replace(match.first_argument, status.to_s)
               end
             end
           end

spec/rubocop/cop/rspec/rails/have_http_status_spec.rb

@@ -45,4 +45,10 @@
       it { expect(res.status).to be(200) }
     RUBY
   end
+
+  it 'ignores statuses that would not coerce to an integer' do
+    expect_no_offenses(<<~RUBY)
+      it { expect(response.status).to eq("404 Not Found") }
+    RUBY
+  end
 end