Refactor a spec #1064
Merged
Refactor a spec #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'autocorrect' shared example group does not pass a correct file name to the cop, and if this cop is tweaked to only inspect factories, this spec fails because the default file name/path is skipped, since it's not a factory path.
Merged
pirj
commented
Oct 27, 2020
|
|
||
| RSpec/ExampleLength: | ||
| Exclude: | ||
| - spec/rubocop/cop/rspec/factory_bot/attribute_defined_statically_spec.rb |
bquorning
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'autocorrect' shared example group does not pass a correct file name to
the cop, and if this cop is tweaked to only inspect factories, this spec
fails because the default file name/path is skipped, since it's not a
factory path.
#1063 depends on this
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).