Remove seemingly unnecessary spec config file #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Nov 14, 2020
Member
pirj
left a comment
pirj
left a comment
There was a problem hiding this comment.
I'm surprised that everything specs still run fine, as I've spent quite some tome crafting this. But I'm very happy to see this go!
Thanks!
Collaborator
Author
I know you have, and I’m as surprised as you are. Do you recall why you found it necessary at the time? Is it just a side-effect of the RuboCop 1.0 changes and the RuboCop RSpec 2.0 changes that leads to it being possible to remove this file now? |
Member
Not really. Looking at PR comments and code comments gives me no idea either. I'll learn from this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was added in #1063, but the specs seem to run fine without it. I confirmed this using RuboCop v1.0.0, v1.1.0, v1.2.0 and v1.3.0. Do we still need this file @pirj?
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).