RSpec/ContextWording: Detect non-string in Prefixes#2059
Merged
ydah merged 1 commit intorubocop:masterfrom Mar 19, 2025
Merged
Conversation
bquorning
commented
Mar 10, 2025
Collaborator
Author
bquorning
left a comment
There was a problem hiding this comment.
Could you add e.g. this to the changelog:
- Fix issue when `Style/ContextWording` is configured with a Prefix being interpreted as a boolean, like `on`. ([@sakuro])
and add [@sakuro]: https://github.com/sakuro towards the bottom of the file.
Collaborator
Author
|
cc @sakuro |
6da303f to
4b4f0ea
Compare
Contributor
|
@bquorning hi, I think you can mark this as ready for review. |
Collaborator
Author
Collaborator
Author
|
@sakuro could you rebase, and squash the commits please? |
f321e29 to
c3345f4
Compare
Contributor
|
@bquorning rebased and squashed |
Member
|
Could you please fixes rubocop offenses? |
Co-authored-by: Benjamin Quorning <22333+bquorning@users.noreply.github.com> Co-authored-by: Phil Pirozhkov <pirj@users.noreply.github.com>
d659b40 to
1a7c2e1
Compare
Contributor
Fixed and squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2051
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).