Skip to content

Comments

Fix offenses for InternalAffairs/ExampleDescription cop#2092

Merged
pirj merged 1 commit intomasterfrom
fixinternal
Jul 10, 2025
Merged

Fix offenses for InternalAffairs/ExampleDescription cop#2092
pirj merged 1 commit intomasterfrom
fixinternal

Conversation

@ydah
Copy link
Member

@ydah ydah commented Jul 9, 2025

Offenses:

spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb:316:8: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
    it 'allows multiple one-liner blocks' do
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb:336:8: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
    it 'allows multiple one-liner blocks with comments' do
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • [-] Updated documentation.
  • [-] Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@ydah ydah requested a review from a team as a code owner July 9, 2025 15:54
```
Offenses:

spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb:316:8: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
    it 'allows multiple one-liner blocks' do
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/rubocop/cop/rspec/empty_line_after_hook_spec.rb:336:8: C: [Corrected] InternalAffairs/ExampleDescription: Description does not match use of expect_offense.
    it 'allows multiple one-liner blocks with comments' do
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
@ydah ydah requested a review from pirj July 10, 2025 04:43
Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pirj pirj merged commit 47f0330 into master Jul 10, 2025
27 checks passed
@pirj pirj deleted the fixinternal branch July 10, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants