Add explanation why RSpec/DescribedClass autocorrection is unsafe#2096
Merged
bquorning merged 1 commit intorubocop:masterfrom Jul 27, 2025
Merged
Add explanation why RSpec/DescribedClass autocorrection is unsafe#2096bquorning merged 1 commit intorubocop:masterfrom
bquorning merged 1 commit intorubocop:masterfrom
Conversation
lovro-bikic
commented
Jul 25, 2025
Comment on lines
-50
to
-57
| # There's a known caveat with rspec-rails's `controller` helper that | ||
| # runs its block in a different context, and `described_class` is not | ||
| # available to it. `SkipBlocks` option excludes detection in all | ||
| # non-RSpec related blocks. | ||
| # | ||
| # To narrow down this setting to only a specific directory, it is | ||
| # possible to use an overriding configuration file local to that | ||
| # directory. |
Contributor
Author
There was a problem hiding this comment.
I moved this up because in the generated documentation it's also above examples:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing safety info on
RSpec/DescribedClass. This cop has unsafe autocorrection.The cop was made unsafe in 3574888. The reason for marking it as unsafe is documented in #795.
Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).If you have created a new cop:
config/default.yml.Enabled: pendinginconfig/default.yml.Enabled: truein.rubocop.yml.VersionAdded: "<<next>>"indefault/config.yml.If you have modified an existing cop's configuration options:
VersionChanged: "<<next>>"inconfig/default.yml.