Skip to content

Bump rubocop version to 1.0 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Bump rubocop version to 1.0 #13

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01fac79
Bump rubocop version to 1.0.
rickselby Nov 6, 2020
df8ae8c
Update rubocop-spec and fix cops
rickselby Nov 7, 2020
9d1b5a2
Update dependency version specifiers
rickselby Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ require:
- rubocop-rspec

AllCops:
TargetRubyVersion: 2.3
TargetRubyVersion: 2.4

# Offense count: 1
# Configuration parameters: CountComments, ExcludedMethods.
Expand Down
4 changes: 1 addition & 3 deletions lib/rubocop/cop/sequel/concurrent_index.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ class ConcurrentIndex < Cop

def on_send(node)
indexes?(node) do |args|
if offensive?(args)
add_offense(node, location: :selector, message: MSG)
end
add_offense(node, location: :selector, message: MSG) if offensive?(args)
end
end

Expand Down
8 changes: 5 additions & 3 deletions rubocop-sequel.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ Gem::Specification.new do |gem|
gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
gem.name = 'rubocop-sequel'
gem.require_paths = ['lib']
gem.version = '0.0.6'
gem.version = '0.1.0'

gem.add_runtime_dependency 'rubocop', '~> 0.55', '>= 0.55'
gem.required_ruby_version = '~> 2.4'

gem.add_runtime_dependency 'rubocop', '~> 1.0', '>= 1.0.0'

gem.add_development_dependency 'rake', '~> 12.3.0', '>= 12.0.0'
gem.add_development_dependency 'rspec', '~> 3.7', '>= 3.7.0'
gem.add_development_dependency 'rubocop-rspec', '~> 1.25.0', '>= 1.25.0'
gem.add_development_dependency 'rubocop-rspec', '~> 2.0', '>= 2.0.0'
gem.add_development_dependency 'sequel', '~> 4.49', '>= 4.49.0'
gem.add_development_dependency 'simplecov', '~> 0.16'
gem.add_development_dependency 'sqlite3', '~> 1.3', '>= 1.3.12'
Expand Down