Skip to content

Remove tempfile if exception is thrown #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove tempfile if exception is thrown #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lib/paperclip/paperclip_processors/transcoder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,12 @@ def make

begin
@cli.run
log "Successfully transcoded #{@basename} to #{dst}"
log "Successfully transcoded #{@basename} to #{dst.path}"
rescue Cocaine::ExitStatusError => e
raise Paperclip::Error, "error while transcoding #{@basename}: #{e}" if @whiny
if @whiny
dst.close!
raise Paperclip::Error, "error while transcoding #{@basename}: #{e}"
end
end
else
log "Unsupported file #{@file.path}"
Expand Down