Do not call subject/let defined methods in after block when the threads are reaped

Author: pitr-ch

spec/concurrent/atomic/count_down_latch_spec.rb

@@ -44,7 +44,8 @@
 
     it 'blocks indefinitely' do
       # test the thread is kill-able
-      in_thread { latch.wait }
+      in_thread(latch) { |l| l.wait }
+      sleep 0.1
     end
 
     context 'count set to zero' do

spec/concurrent/atomic/event_spec.rb

@@ -112,6 +112,11 @@ module Concurrent
         expect(latch.wait(0.1)).to be true
       end
 
+      it 'blocks indefinitely' do
+        in_thread{ subject.wait }
+        sleep 0.1
+      end
+
       it 'stops waiting when the timer expires' do
         subject.reset
         latch = CountDownLatch.new(1)

spec/concurrent/atomic/read_write_lock_spec.rb

@@ -89,15 +89,15 @@ module Concurrent
         latch_2 = Concurrent::CountDownLatch.new(1)
         latch_3 = Concurrent::CountDownLatch.new(1)
 
-        in_thread do
+        t1 = in_thread do
           latch_1.wait(1)
           subject.acquire_write_lock
           latch_2.count_down
           latch_3.wait(1)
           subject.release_write_lock
         end
 
-        in_thread do
+        t2 = in_thread do
           latch_2.wait(1)
           subject.acquire_write_lock
           subject.release_write_lock
@@ -109,6 +109,8 @@ module Concurrent
         expect(subject).to have_waiters
 
         latch_3.count_down
+
+        join_with t1, t2
       end
     end
 

spec/concurrent/synchronization_spec.rb

@@ -7,6 +7,7 @@ module Concurrent
     RSpec.shared_examples :attr_volatile do
 
       specify 'older writes are always visible' do
+        store = store()
         store.not_volatile = 0
         store.volatile     = 0
 

spec/support/example_group_extensions.rb

@@ -32,6 +32,9 @@ def in_thread(*args, &block)
       t
     end
 
+    def join_with(*threads, timeout: 0.1)
+      Array(threads).each { |t| expect(t.join(timeout)).not_to eq nil }
+    end
   end
 end