Skip to content

Suppress empty content in CHANGELOG #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sue445 merged 1 commit into from
Nov 21, 2024
Merged

Suppress empty content in CHANGELOG #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,13 @@
* Add rbs to `go_gem` gem by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/215
* Add rake task helper for go by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/214

### Other changes

## ruby_h_to_go
* No changes

## Other
### Bugfixes
* Fix changelog_generator on CI by @sue445 in https://github.com/ruby-go-gem/go-gem-wrapper/pull/212

### Other changes

**Full Changelog**: https://github.com/ruby-go-gem/go-gem-wrapper/compare/v0.2.4...v0.3.0

# [v0.2.4](https://github.com/ruby-go-gem/go-gem-wrapper/releases/tag/v0.2.4) - 2024-11-16
Expand Down
12 changes: 7 additions & 5 deletions _tools/changelog_generator/changelog_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,14 @@ def generate_category_changelog(prs) # rubocop:disable Metrics/AbcSize,Metrics/C
found_pr_numbers.include?(pr["number"]) || pr["label_names"].include?("chore")
end

lines << "### Other changes"
other_prs.each do |pr|
lines << generate_changelog_line(pr)
unless other_prs.empty?
lines << "### Other changes"
other_prs.each do |pr|
lines << generate_changelog_line(pr)
end
found_pr_numbers.push(*other_prs.map { |pr| pr["number"] })
lines << ""
end
found_pr_numbers.push(*other_prs.map { |pr| pr["number"] })
lines << ""

return "* No changes\n\n" if found_pr_numbers.empty?

Expand Down
Loading