Skip to content

fix: Accept nil serializer #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2025
Merged

fix: Accept nil serializer #92

merged 4 commits into from
Jun 8, 2025

Conversation

mateusnava
Copy link
Contributor

No description provided.

@mateusnava mateusnava force-pushed the fix/serializer-nil branch 7 times, most recently from 2b037f7 to 39ed733 Compare August 30, 2019 21:22
@mateusnava
Copy link
Contributor Author

mateusnava commented Sep 2, 2019 •
edited
Loading

The error is undefined method deep_dup for {}:Hash - #90

@dblock
Copy link
Member

dblock commented May 26, 2025

Very old but possibly still needed, rebase?

@dblock
Copy link
Member

dblock commented May 31, 2025

Rubocop is unhappy, please?

dblock
dblock approved these changes Jun 8, 2025
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I wonder whether we can memoize @serializer_class ||= ... to improve performance but maybe it doesn't matter.

Not sure what's up with Danger.

@dblock dblock merged commit cce31fe into ruby-grape:master Jun 8, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateusnava @dblock @samsonjs