Update CI matrix and Gemfile for multi-version grape testing #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expand test matrix in .github/workflows/test.yml to include various ruby and grape version combinations (1.8.0, 2.0.0, 2.1.3, 2.2.0, HEAD). - Update Ruby setup to utilize new matrix entries. - Add conditional gem specification for grape in Gemfile based on GRAPE_VERSION environment variable.
To much. |
…ing of grape, grape-swagger, and grape-entity
- Test grape, grape-swagger, and grape-entity with one stable and one development version each. - Reduce total combinations to improve speed and maintainability without sacrificing essential coverage.
…e-entity versions
Much better now. |
dblock
approved these changes
Feb 23, 2025
There was a problem hiding this comment.
Thanks for doing this!
Personally I dislike having to use include and exclude to limit the exploding matrix. The one in Grape is particularly egregious (https://github.com/ruby-grape/grape/blob/master/.github/workflows/test.yml#L22). I much prefer explicit declarations like in https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/test.yml#L8. Maybe someone feels as strongly as me about it ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier for us to test the gem with different versions of grape and Ruby. By expanding our test matrix and updating the Gemfile, we can check that our changes work with a wider range of grape versions. This helps catch any issues early and ensures our gem stays compatible with future updates.