Skip to content

Fix Set type with values #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

Fix Set type with values #2507

merged 1 commit into from
Oct 23, 2024

Conversation

nikolai-b
Copy link
Contributor

Not sure if this wants a change log as it feels more like a bug fix.

dblock
dblock requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

  1. Yes this needs a CHANGELOG entry since it's a bug fix, thanks for fixing it!
  2. Should the check be doing an is_a?(Enumerable)?

@dblock dblock merged commit 139e96b into ruby-grape:master Oct 23, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblock dblock dblock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikolai-b @dblock