Skip to content

Delegate cookies management to Grape::Request #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2025
Merged

Delegate cookies management to Grape::Request #2549

merged 5 commits into from
Mar 28, 2025

Conversation

@ericproulx
Copy link
Contributor

This PR delegates cookies to Grape::Request like the actual params and headers are. Minor tweaks have been made in Grape::Cookies:

  • Rack's cookies will be read only if the API calls cookies
  • Response cookies management is now done with a Set instead of Hash containing true
  • Uses Forwardable module

@ericproulx ericproulx requested a review from dblock March 23, 2025 16:19
@ericproulx ericproulx marked this pull request as ready for review March 23, 2025 16:19
dblock
dblock reviewed Mar 23, 2025
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a moment to grok through this otherwise simple change, see if you want any of my suggestions?

@ericproulx
Copy link
Contributor Author

Took me a moment to grok through this otherwise simple change, see if you want any of my suggestions?

Great suggestion! I did some rework

@dblock
Copy link
Member

dblock commented Mar 28, 2025

Took me a moment to grok through this otherwise simple change, see if you want any of my suggestions?

Great suggestion! I did some rework

Much better!

@dblock dblock merged commit 809add4 into ruby-grape:master Mar 28, 2025
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dblock dblock dblock left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericproulx @dblock