Remove Grape::Http::Headers #2554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use plain HTTP_ or real header name instead of referencing to Http::Headers:: Remove Grape::Util::Lazy::Object
dblock
requested changes
Apr 5, 2025
Member
dblock
left a comment
dblock
left a comment
There was a problem hiding this comment.
I think this needs an UPGRADING on the invalid header that can be set and the removal of some constants.
CHANGELOG.md
Outdated
| * [#2540](https://github.com/ruby-grape/grape/pull/2540): Introduce Params builder with symbolized short name - [@ericproulx](https://github.com/ericproulx). | ||
| * [#2550](https://github.com/ruby-grape/grape/pull/2550): Drop ActiveSupport 6.0 - [@ericproulx](https://github.com/ericproulx). | ||
| * [#2549](https://github.com/ruby-grape/grape/pull/2549): Delegate cookies management to `Grape::Request` - [@ericproulx](https://github.com/ericproulx). | ||
| * [#2554](https://github.com/ruby-grape/grape/pull/2554): Remove Grape::Http::Headers - [@ericproulx](https://github.com/ericproulx). |
Contributor
Author
There was a problem hiding this comment.
Well its a fix .. but not really. We've been using Grape::Util::Header for a while and since then, Grape is compliant with Rack's spec about headers.
Add UPGRADING notes Add X-Access-Token in list of headers
ericproulx
commented
Apr 6, 2025
dblock
approved these changes
Apr 9, 2025
Member
|
Rebase? Feel free to merge yourself. |
ericproulx
added a commit
to ericproulx/grape
that referenced
this pull request
Jun 22, 2025
* Move HTTP_HEADERS in Grape::Request and renew known headers Use plain HTTP_ or real header name instead of referencing to Http::Headers:: Remove Grape::Util::Lazy::Object * Add few headers * Add other headers * Add other known headers and sort * CHANGELOG.md entry * Fix CHANGELOG.md Add UPGRADING notes Add X-Access-Token in list of headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
Grape::Http::Headers. Since most constantsHTTP_were just literal string and Grape's uses#frozen_string_literal: true, it made sense to just use the literal string wherever needed. Here's a list of notable changes:Grape::Http::Headers::SUPPORTED_METHODShas been moved toGrapemodule.Grape::Http::Headers::HTTP_HEADERShas been moved toGrape::Requestand its now calledKNOWN_HEADERS. The last has been revisited to reflect Rack 3's KNOWN_HEADERS. Its not an exact copy. Grape's version has more.Grape::Util::Lazy::Objectno longer exists. Solely used byGrape::Http::Headers::HTTP_HEADERSGrape::Http::Headers.find_supported_methodno long exists. It wasn't used.to_swhen callingheaderssince its not just a plain{}but aGrape::Util::Headers. Fix Grape allows invalid headers to be set. #2334