Skip to content

Conversation

ericproulx
Copy link
Contributor

This PR applies a small refactor to Grape::Middleware::Versioner::Base.

  • Defines method dynamically
  • Evaluate error_headers when initializing
  • Simplify potential version check.

@ericproulx ericproulx requested a review from dblock July 13, 2025 14:47
@grape-bot
Copy link

grape-bot commented Jul 13, 2025

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@ericproulx ericproulx force-pushed the small_refactor_versioner_middleware branch from c85ece0 to 89b8d0a Compare July 13, 2025 14:48
@ericproulx ericproulx force-pushed the small_refactor_versioner_middleware branch from 89b8d0a to fab7110 Compare July 13, 2025 14:49
@ericproulx ericproulx marked this pull request as ready for review July 15, 2025 17:23
@ericproulx
Copy link
Contributor Author

I gonna reopen it stacked on the current ones.

@ericproulx ericproulx closed this Sep 20, 2025
@ericproulx ericproulx deleted the small_refactor_versioner_middleware branch September 20, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants