Fix routes memoization

[ericproulx]

Fix routes memoization

Base: master
Branch: fix_routes_memoization

Summary

Ensure routes memoization works reliably by making routes a non-overridable method and tightening specs to verify the memoization behavior directly.

Motivation / Context

• The routes method was eligible to be overridden, which could inadvertently break memoization and force repeated route computation.
• This PR safeguards memoization and updates tests to validate the behavior without relying on private implementation details.

Changes

• Make routes non-overridable to preserve memoization guarantees.
• Improve specs so they assert actual memoization effects rather than depending on private methods.

Implementation Notes

• Commit(s):
  • 017e762 — Add routes as a non overridable methods so that memoization works properly. Added a better specs so that a private method is not expected and memoization is really tested. (Eric Proulx)

Files Changed (4)

• lib/grape/api.rb
• lib/grape/api/instance.rb
• lib/grape/dsl/routing.rb
• spec/grape/dsl/routing_spec.rb

Diff Stats

4 files changed, 15 insertions(+), 18 deletions(-)

Testing

• Added/updated specs in spec/grape/dsl/routing_spec.rb to validate memoization behavior.
• Run:
  • bundle install
  • bundle exec rspec spec/grape/dsl/routing_spec.rb
  • bundle exec rspec

Backwards Compatibility / Risk

• Low risk for typical usage; behavior is preserved with improved guarantees.
• Potentially breaking only if external code previously overrode routes. Marking it non-overridable is intentional to protect memoization semantics.

Checklist

• Tests updated/added
• No public API changes beyond making routes non-overridable
• Changelog entry considered (if maintainers require)

Notes for Reviewers

• Focus on how routes is protected from overriding and how tests assert memoization without relying on private methods.