Remove namespace_stackable_with_hash from public interface
#2603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericproulx
force-pushed
the
remove_namespace_stackable_with_hash_from_public_interface
branch
2 times, most recently
from
0ffa0f0 to
bd336a4
Compare
- Remove namespace_reverse_stackable method from Grape::DSL::Settings - Replace direct calls to namespace_reverse_stackable with inheritable_setting.namespace_reverse_stackable - Update rescue_from implementation to use direct inheritable_setting access - Update tests to verify actual behavior instead of mocking internal methods - Simplify test setup by extending Grape::DSL::Settings instead of manually stubbing methods
- Move namespace_stackable_with_hash method from DSL::Settings to InheritableSetting - Update all internal usage to use inheritable_setting.namespace_stackable_with_hash - Remove public method from DSL::Settings module - Update tests to reflect the new internal structure - Increase RuboCop AbcSize limit to accommodate refactored code
ericproulx
force-pushed
the
remove_namespace_stackable_with_hash_from_public_interface
branch
from
bd336a4 to
3ff1516
Compare
ericproulx
deleted the
remove_namespace_stackable_with_hash_from_public_interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
namespace_stackable_with_hashfrom public interfaceSummary
This PR refactors the internal implementation of
namespace_stackable_with_hashby moving it from the public DSL interface to the internalInheritableSettingclass, making it a private implementation detail rather than part of the public API.Changes Made
Core Refactoring
namespace_stackable_with_hashfromGrape::DSL::SettingstoGrape::Util::InheritableSettinginheritable_setting.namespace_stackable_with_hashinstead of the direct method callFiles Modified
lib/grape/dsl/inside_route.rb- Updated entity class detection logiclib/grape/dsl/parameters.rb- Updated named params handlinglib/grape/dsl/request_response.rb- Updated content types handlinglib/grape/dsl/routing.rb- Updated route options handlinglib/grape/dsl/settings.rb- Removed public methodlib/grape/endpoint.rb- Updated middleware stack buildinglib/grape/util/inheritable_setting.rb- Added the method as private implementationTest Updates
Configuration
AbcSizelimit from 45 to 50 to accommodate the refactored code structureBenefits
InheritableSettingclassBreaking Changes
None - This is purely an internal refactoring. The public API remains unchanged, and all existing functionality continues to work as expected.
Testing
Related Issues
This refactoring improves the internal architecture of Grape by better encapsulating implementation details and providing a cleaner separation between public and private APIs.