Add Rack 3.2 Support #2605
Merged
Add Rack 3.2 Support #2605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericproulx
force-pushed
the
add_rack_3_2_gemfile
branch
3 times, most recently
from
2103e86 to
a8e9f0a
Compare
- Remove namespace_reverse_stackable method from Grape::DSL::Settings - Replace direct calls to namespace_reverse_stackable with inheritable_setting.namespace_reverse_stackable - Update rescue_from implementation to use direct inheritable_setting access - Update tests to verify actual behavior instead of mocking internal methods - Simplify test setup by extending Grape::DSL::Settings instead of manually stubbing methods
- Move namespace_stackable_with_hash method from DSL::Settings to InheritableSetting - Update all internal usage to use inheritable_setting.namespace_stackable_with_hash - Remove public method from DSL::Settings module - Update tests to reflect the new internal structure - Increase RuboCop AbcSize limit to accommodate refactored code
- Add enable_coverage :branch to SimpleCov.start block - Improves test coverage reporting by tracking branch coverage - Helps identify untested code paths and conditional logic
- Add gemfiles/rack_3_2.gemfile for testing with Rack ~> 3.2 - Update GitHub Actions workflow to include rack_3_2.gemfile in test matrix - Ensures compatibility with latest Rack 3.2.x versions
ericproulx
force-pushed
the
add_rack_3_2_gemfile
branch
from
a8e9f0a to
c0a3f75
Compare
|
@ericproulx I merged this one, you can close the intermediate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rack 3.2 Support
Summary
This PR adds support for testing Grape with Rack 3.2.x versions by introducing a new gemfile and updating the CI workflow to include it in the test matrix.
Changes
Added
gemfiles/rack_3_2.gemfile- Tests compatibility with Rack ~> 3.2.github/workflows/test.ymlto includerack_3_2.gemfilein the test matrixModified
Testing
The changes ensure that Grape is tested against Rack 3.2.x versions across all supported Ruby versions (3.0, 3.1, 3.2, 3.3, 3.4). This maintains backward compatibility while ensuring forward compatibility with the latest Rack releases.
Impact
Related
This follows the existing pattern of supporting multiple Rack versions as seen with:
gemfiles/rack_2_0.gemfile(Rack 2.0.x)gemfiles/rack_3_0.gemfile(Rack 3.0.x)gemfiles/rack_3_1.gemfile(Rack 3.1.x)gemfiles/rack_3_2.gemfile(Rack 3.2.x) ← NewChecklist