Remove namespace_stackable and namespace_inheritable from public API #2607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericproulx
force-pushed
the
remove_namespace_stackable_and_inheritable_from_public_space
branch
from
a8dada4 to
2f69d09
Compare
ericproulx
force-pushed
the
remove_namespace_stackable_and_inheritable_from_public_space
branch
3 times, most recently
from
2e12646 to
896892d
Compare
|
Failures in dry_validation look legit. |
ericproulx
force-pushed
the
remove_namespace_stackable_and_inheritable_from_public_space
branch
from
896892d to
8f90af9
Compare
- Refactor internal implementation to use inheritable_setting directly - Remove public access to namespace_stackable and namespace_inheritable methods - Update DSL modules to use internal configuration access - Add equality methods to Namespace class for proper comparison - Update tests to reflect internal API changes - Maintain backward compatibility for public-facing methods
ericproulx
force-pushed
the
remove_namespace_stackable_and_inheritable_from_public_space
branch
from
8f90af9 to
a562a50
Compare
dblock
reviewed
Sep 29, 2025
|
|
||
| Metrics/AbcSize: | ||
| Max: 50 | ||
| Max: 80 # TODO: revert to 50 once the refactor of public api is done. |
There was a problem hiding this comment.
I just run rubocop -a ; rubocop --auto-gen-config.
dblock
deleted the
remove_namespace_stackable_and_inheritable_from_public_space
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove namespace_stackable and namespace_inheritable from public API
Summary
This PR refactors the internal implementation of Grape's namespace configuration system by removing public access to
namespace_stackableandnamespace_inheritablemethods while maintaining backward compatibility for public-facing APIs.Changes Made
Core Refactoring
cascademethod implementation to useinheritable_settingdirectlyeql?,==,hash) for better object comparisonFiles Modified
lib/grape/api/instance.rb- Refactored cascade method and removed public access methodslib/grape/namespace.rb- Added equality methods for proper namespace comparisonlib/grape/dsl/*.rb- Updated DSL modules to use internal configurationlib/grape/endpoint.rb- Refactored to use internal configuration accesslib/grape/middleware/auth/dsl.rb- Updated authentication DSLlib/grape/validations/*.rb- Updated validation modulesTest Updates
Benefits
Breaking Changes
None - This is an internal refactoring that maintains backward compatibility for all public APIs.
Testing
Migration Guide
No migration required - this change is transparent to end users of the Grape gem.
Related Issues
This refactoring addresses internal code organization and API cleanliness without affecting external functionality.