Add Ruby 4.0 to CI #443
Open
Add Ruby 4.0 to CI #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make bind timeout test robust against message variations Ruby 4.0 changed socket timeout handling, which can result in different timeout error messages compared to Ruby 3.x (see ruby/ruby#15582). The bind timeout integration test previously relied on exact string matching, causing failures despite valid timeouts. This change relaxes the assertion to check for expected message fragments instead, making the test resilient across Ruby versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
minor variations in timeout error messages.
Why this is needed
Ruby 4.0 introduces changes in socket timeout handling, which can
result in different timeout error message wording compared to
previous Ruby versions.
The existing test relied on exact string matching and could fail
on Ruby 4.0 even when a timeout occurred correctly. The assertion
has been updated to check whether the error message contains one
of the expected fragments instead, making the test robust across
Ruby versions.
Related Ruby change:
ruby/ruby#15582
Notes
This PR does not change runtime behavior. It only updates CI
coverage and improves test stability when running on Ruby 4.0.